Add ScaleControl to the map for metric unit display#71
Open
AdeelTahir-SE wants to merge 2 commits intoopenzim:mainfrom
Open
Add ScaleControl to the map for metric unit display#71AdeelTahir-SE wants to merge 2 commits intoopenzim:mainfrom
AdeelTahir-SE wants to merge 2 commits intoopenzim:mainfrom
Conversation
benoit74
requested changes
Mar 26, 2026
Collaborator
benoit74
left a comment
benoit74
left a comment
There was a problem hiding this comment.
Please:
- add a changelog entry
- link the PR to the issue
- share a screenshot so that participants can comment on the result without needing to re-create a ZIM on their own (most don't want to loose time on this, and I'm not sure issue author is even able to do that)
…d8bbwe\TempState\Recordings\20260327-1120-01.6980157.mp4
Author
|
the scale control has been successfully added to the map. Recording.2026-03-27.162031.mp4
|
Collaborator
|
@sga-13 would this match what you expect? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did:
Added a persistent map length scale to the UI so users can always estimate real world distance at the current zoom level. fixes #46
What changed:
Added MapLibre’s built-in ScaleControl to the map.
Placed the scale at the bottom-right so it stays visible at all times.
Kept the implementation minimal and focused (single JS change).